Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-4448

delete unused variable in ZeppelinServer.java

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.9.0
    • zeppelin-server
    • None

    Description

      I see the method in ZeppelinServer.java

      ```

      private static void setupNotebookServer(
      WebAppContext webapp, ZeppelinConfiguration conf, ServiceLocator serviceLocator)

      { String maxTextMessageSize = conf.getWebsocketMaxTextMessageSize(); final ServletHolder servletHolder = new ServletHolder(serviceLocator.getService(NotebookServer.class)); servletHolder.setInitParameter("maxTextMessageSize", maxTextMessageSize); final ServletContextHandler context = new ServletContextHandler(ServletContextHandler.SESSIONS); webapp.addServlet(servletHolder, "/ws/*"); }

      ```

      The variable `context` is created but not used, is it intentional ?

      Attachments

        Issue Links

          Activity

            People

              iamabug Xiang Zhang
              iamabug Xiang Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m