[ZEPPELIN-4201] JDBC documentation for common.max_rows not accurate

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.8.1
• Component/s: documentation
• Flags: Important
• Assignee: Unassigned
• Reporter: Jia Long Loh
• Created: 19/Jun/19 09:50
• Updated: 19/Jun/19 09:50

Description

In the documentation for 0.8.1, it is stated that `common.max_count` is used to control the number of output rows from the jdbc.

However, a recent change here to 0.8.1 has resulted in `setMaxRows` using the MAX_ROWS_KEY = "zeppelin.jdbc.maxRows". Rows above 1000 seem to be silently dropped as per the documentation here.

This is very misleading (and even quite dangerous), as many people would assume that as per the documentation, it is common.max_count that controls the number of rows, and because the other rows are silently dropped, this could result in inaccurate results.

We should highlight in the documentation that zeppelin.jdbc.maxRows needs to be set to control the number of rows the jdbc returns.