Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-3713

Remove paragraph text and title from NotebookService.runParagraph

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Critical
    • Resolution: Unresolved
    • 0.9.0
    • None
    • zeppelin-server
    • None

    Description

      NotebookService.runParagraph has paragraph text and title as args, it seems to be unnecessary, because paragraphs extracted from the note already contains them. Also it might cause new bugs related to incorrect text/title passing.

      For example, bug in NotebookRestApi.runParagraph():

      @POST
      @Path("job/{noteId}/{paragraphId}")
      @ZeppelinApi
      public Response runParagraph(@PathParam("noteId") String noteId,
      @PathParam("paragraphId") String paragraphId, String message)
      throws IOException, IllegalArgumentException {
      
      ...
      
      notebookService.runParagraph(
          noteId, paragraphId, "", "", params,
          new HashMap<String, Object>(), false, getServiceContext(), new RestServiceCallback<>());
      return new JsonResponse<>(Status.OK).build();
      }
      

      all paragraphs processing as blank.

      Attachments

        Issue Links

          Activity

            People

              egorklimov George Klimov
              egorklimov George Klimov
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: