[ZEPPELIN-3344] Revert comments in JDBC interpreter

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0, 0.9.0
• Fix Version/s: 0.8.0
• Assignee: Maxim Belousov
• Reporter: Maxim Belousov
• Created: 16/Mar/18 08:25
• Updated: 01/Apr/18 03:29
• Resolved: 01/Apr/18 03:29

Description

In Zeppelin the paragraph can contain multiple SQL queries delimeted by ';'.
The original purpose of PR2518 [1] was correct processing of ';'. This was done via full removing comments from code.
Unfortunately Apache Phoenix uses hooks in comments [2].
Thus we should not delete comments in scripts.

There was discussion about comment rules for different databases (solr). The right way is keep style. Thus analysts can copy queries to another tool and can get same results and errors.

[1]. https://github.com/apache/zeppelin/pull/2158 ZEPPELIN-2279 excluded comments from SQL
[2]. https://forcedotcom.github.io/phoenix/#hint

Issue Links

• links to: GitHub Pull Request #2876