Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      On commit https://github.com/apache/zeppelin/commit/32517c9d9fbdc2235560388a47f9e3eff4ec4854 , we made 2 changes that I feel need to be reverted.

      • zeppelin-server/pom.xml: project.version to "0.8.0-SNAPSHOT"
      • zeppelin-zengine/pom.xml: project.version to "0.8.0-SNAPSHOT"

      Reason for it, it should be possible to override project version by running https://github.com/apache/zeppelin/blob/d92d14aae8678bba8b01d19abc8bbf875585e0ea/dev/change_zeppelin_version.sh#L54-L54

        Issue Links

          Activity

          Hide
          zjffdu Jeff Zhang added a comment -

          Make sense, thanks for reporting this. Nelson Costa

          Show
          zjffdu Jeff Zhang added a comment - Make sense, thanks for reporting this. Nelson Costa
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user necosta opened a pull request:

          https://github.com/apache/zeppelin/pull/2584

          ZEPPELIN-2928 Hotfix on maven set version functionality

              1. What is this PR for?
                Hotfix on a recent commit that removed the version soft-coded variable and introduced hard-coded references to version tag.
              1. What type of PR is it?
                [Bug Fix | Hot Fix ]
              1. What is the Jira issue?
              1. How should this be tested?
                Run "mvn versions:set -DprocessDependencies=false -DnewVersion=0.8.0-SNAPSHOT-123"
              1. Questions:
          • Does the licenses files need update? N
          • Is there breaking changes for older versions? N
          • Does this needs documentation? N

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nokia/zeppelin zeppelin-2928

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/2584.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2584


          commit f5ccf89bbf174f72d4aa8b07f68dc708dbc77264
          Author: Nelson Costa <nelson.costa85@gmail.com>
          Date: 2017-09-13T08:16:31Z

          ZEPPELIN-2928 Hotfix on maven set version functionality


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user necosta opened a pull request: https://github.com/apache/zeppelin/pull/2584 ZEPPELIN-2928 Hotfix on maven set version functionality What is this PR for? Hotfix on a recent commit that removed the version soft-coded variable and introduced hard-coded references to version tag. What type of PR is it? [Bug Fix | Hot Fix ] What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2928 How should this be tested? Run "mvn versions:set -DprocessDependencies=false -DnewVersion=0.8.0-SNAPSHOT-123" Questions: Does the licenses files need update? N Is there breaking changes for older versions? N Does this needs documentation? N You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin-2928 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2584 commit f5ccf89bbf174f72d4aa8b07f68dc708dbc77264 Author: Nelson Costa <nelson.costa85@gmail.com> Date: 2017-09-13T08:16:31Z ZEPPELIN-2928 Hotfix on maven set version functionality
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user necosta commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          Hi @zjffdu , @Leemoonsoo
          Should be an easy one to get merged. Let me know if anything does not make sense. Cheers.

          Show
          githubbot ASF GitHub Bot added a comment - Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2584 Hi @zjffdu , @Leemoonsoo Should be an easy one to get merged. Let me know if anything does not make sense. Cheers.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          LGTM, wait for CI pass

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2584 LGTM, wait for CI pass
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user necosta commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          Hi @zjffdu , are there known issues on the CI? I'm a bit puzzled.
          I am 1 commit on top of master and the CI keeps failing on this stage: https://travis-ci.org/nokia/zeppelin/jobs/274939134. Any suggestions?
          I have cleaned the cache already, did not work... Thanks

          Show
          githubbot ASF GitHub Bot added a comment - Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2584 Hi @zjffdu , are there known issues on the CI? I'm a bit puzzled. I am 1 commit on top of master and the CI keeps failing on this stage: https://travis-ci.org/nokia/zeppelin/jobs/274939134 . Any suggestions? I have cleaned the cache already, did not work... Thanks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          Don't worry. This is known issue tracked in ZEPPELIN-2927.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2584 Don't worry. This is known issue tracked in ZEPPELIN-2927 .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user necosta commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          Missed that bug report. Thanks.
          Ok, feel free to merge change or wait for more feedback.

          Show
          githubbot ASF GitHub Bot added a comment - Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2584 Missed that bug report. Thanks. Ok, feel free to merge change or wait for more feedback.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user necosta commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          Actually there is one more override missing on zeppelin-jupyter. I'll confirm tomorrow I got them all fixed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2584 Actually there is one more override missing on zeppelin-jupyter. I'll confirm tomorrow I got them all fixed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          That's correct, please go ahead @necosta

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2584 That's correct, please go ahead @necosta
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user necosta commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          @zjffdu
          Done. Ready for final review. Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2584 @zjffdu Done. Ready for final review. Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjffdu commented on the issue:

          https://github.com/apache/zeppelin/pull/2584

          LGTM, will merge it if no more comment

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2584 LGTM, will merge it if no more comment
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/2584

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2584

            People

            • Assignee:
              nelsonc Nelson Costa
              Reporter:
              nelsonc Nelson Costa
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development