Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.6.2
    • Fix Version/s: 0.7.0, 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      Elasticsearch now has a good Java client that talks to ES via its HTTP API (vs. TransportClient that does not). It would be good if Zeppelin could use that so that it can talk to ES clusters and services that expose only HTTP API (e.g. http://sematext.com/logsene/ exposes the ES HTTP API, but not the Java one, so one cannot use TransportClient to talk to it)

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bbonnin opened a pull request:

          https://github.com/apache/zeppelin/pull/1902

          ZEPPELIN-1821 Add HTTP client to elasticsearch interpreter

              1. What is this PR for?
                Add HTTP client to elasticsearch interpreter.
              1. What type of PR is it?
                Feature
              1. Todos
          • [X] - Source code
          • [X] - Tests
          • [X] - License
          • [X] - Docs
              1. What is the Jira issue?
                https://issues.apache.org/jira/browse/ZEPPELIN-1821
              1. How should this be tested?
          • Start an Elasticsearch node
          • Configure the elasticsearch interpreter to use http
          • Create queries in a note using elasticsearch
              1. Screenshots (if appropriate)
              1. Questions:
          • Does the licenses files need update? Yes
          • Is there breaking changes for older versions? No
          • Does this needs documentation? Yes

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bbonnin/zeppelin master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/zeppelin/pull/1902.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1902


          commit f4c5ac39fe0634fc98e537c965163e6fe4d4f3ce
          Author: Bruno Bonnin <bbonnin@gmail.com>
          Date: 2017-01-02T16:48:30Z

          HTTP-based Elasticsearch client

          commit 549db396ee3ed1ec37fb62afcf177b2c9469723e
          Author: Bruno Bonnin <bruno.bonnin@myscript.com>
          Date: 2017-01-15T10:47:36Z

          Add HTTP client to elasticsearch interpreter

          commit 28b98054450457373081343c476a89534ec56173
          Author: Bruno Bonnin <bruno.bonnin@myscript.com>
          Date: 2017-01-15T11:28:41Z

          Update img


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bbonnin opened a pull request: https://github.com/apache/zeppelin/pull/1902 ZEPPELIN-1821 Add HTTP client to elasticsearch interpreter What is this PR for? Add HTTP client to elasticsearch interpreter. What type of PR is it? Feature Todos [X] - Source code [X] - Tests [X] - License [X] - Docs What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1821 How should this be tested? Start an Elasticsearch node Configure the elasticsearch interpreter to use http Create queries in a note using elasticsearch Screenshots (if appropriate) Questions: Does the licenses files need update? Yes Is there breaking changes for older versions? No Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbonnin/zeppelin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1902.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1902 commit f4c5ac39fe0634fc98e537c965163e6fe4d4f3ce Author: Bruno Bonnin <bbonnin@gmail.com> Date: 2017-01-02T16:48:30Z HTTP-based Elasticsearch client commit 549db396ee3ed1ec37fb62afcf177b2c9469723e Author: Bruno Bonnin <bruno.bonnin@myscript.com> Date: 2017-01-15T10:47:36Z Add HTTP client to elasticsearch interpreter commit 28b98054450457373081343c476a89534ec56173 Author: Bruno Bonnin <bruno.bonnin@myscript.com> Date: 2017-01-15T11:28:41Z Update img
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          great Contribution for elasticsearch interpreter! This PR helps us to support ES 5.0 easily!

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 great Contribution for elasticsearch interpreter! This PR helps us to support ES 5.0 easily!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jongyoul commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          @1ambda Can you review this PR deeply?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1902 @1ambda Can you review this PR deeply?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          @bbonnin Recently we have fixed some flaky test on master branch. Could you try rebase and see if CI becomes green?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 @bbonnin Recently we have fixed some flaky test on master branch. Could you try rebase and see if CI becomes green?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bbonnin commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          It looks better now, all is green !

          Show
          githubbot ASF GitHub Bot added a comment - Github user bbonnin commented on the issue: https://github.com/apache/zeppelin/pull/1902 It looks better now, all is green !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          @bbonnin 👍

          @jongyoul I will take a look more deeply

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @bbonnin 👍 @jongyoul I will take a look more deeply
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          LGTM @1ambda do you have any comment?

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 LGTM @1ambda do you have any comment?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jaspinderdineout commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          When will this be merged?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jaspinderdineout commented on the issue: https://github.com/apache/zeppelin/pull/1902 When will this be merged?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          Works well as described.

          • tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only)
          • code looks nice. well abstracted client classes is shipped with some tests.

          there some commented code lines. LGTM except that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 Works well as described. tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only) code looks nice. well abstracted client classes is shipped with some tests. there some commented code lines. LGTM except that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          CI failure looks unrelated, since it only removed commented-out code from last CI success.
          Thanks @bbonnin for great contribution.
          LGTM and merge to master if no further discussions!

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1902 CI failure looks unrelated, since it only removed commented-out code from last CI success. Thanks @bbonnin for great contribution. LGTM and merge to master if no further discussions!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/zeppelin/pull/1902

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1902
          Hide
          otis Otis Gospodnetic added a comment -

          Thanks Bruno Bonnin!
          I see Fix Version is 0.8.0, but I see 0.7.0 is not out yet. Is there any chance this feature will be in 0.7?

          Show
          otis Otis Gospodnetic added a comment - Thanks Bruno Bonnin ! I see Fix Version is 0.8.0, but I see 0.7.0 is not out yet. Is there any chance this feature will be in 0.7?
          Hide
          moon Lee moon soo added a comment -

          Since 0.7.0 branch cut, 0.7.0 branch receives only bug fixes to stabilize release.

          However, I think changes made by this issue are isolated inside of elasticsearch interpreter submodule.
          Mina Lee What do you think?

          Show
          moon Lee moon soo added a comment - Since 0.7.0 branch cut , 0.7.0 branch receives only bug fixes to stabilize release. However, I think changes made by this issue are isolated inside of elasticsearch interpreter submodule. Mina Lee What do you think?
          Hide
          Mina Lee Mina Lee added a comment -

          Considering Zeppelin release cycle, if we don't include this improvement in 0.7.0 release, it will take up to 1 year for user to use this feature. And as moon said it will affect only elasticsearch module and if there is bug we can fix it and provide maintenance release so I am merging it into branch-0.7.

          Show
          Mina Lee Mina Lee added a comment - Considering Zeppelin release cycle, if we don't include this improvement in 0.7.0 release, it will take up to 1 year for user to use this feature. And as moon said it will affect only elasticsearch module and if there is bug we can fix it and provide maintenance release so I am merging it into branch-0.7.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jaspinderdineout commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          Why is this not merged into apache:master?

          Show
          githubbot ASF GitHub Bot added a comment - Github user jaspinderdineout commented on the issue: https://github.com/apache/zeppelin/pull/1902 Why is this not merged into apache:master?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user 1ambda commented on the issue:

          https://github.com/apache/zeppelin/pull/1902

          @jaspinderdineout This was merged into master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @jaspinderdineout This was merged into master.

            People

            • Assignee:
              bbonnin Bruno Bonnin
              Reporter:
              otis Otis Gospodnetic
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development