Uploaded image for project: 'Zeppelin'
  1. Zeppelin
  2. ZEPPELIN-16

Some failures from Spark and SparkSql note execution are not reported

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.0
    • Component/s: None
    • Labels:
      None

      Description

      Some spark and spark sql note execution can silently fail - the result progress line is drawn but no results are returned. For example, run the tutorial sql script with a typo in it, such as changing the table name to non_existent.

      The root cause seems to be the following pattern:

      return new InterpreterResult(Code.ERROR, e.getMessage());
      

      Unfortunately, when the Spark framework throws an InvocationTargetException, the message is empty.

      I will provide a patch for this shortly.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user RamVenkatesh opened a pull request:

          https://github.com/apache/incubator-zeppelin/pull/16

          ZEPPELIN-16

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/RamVenkatesh/incubator-zeppelin ZEPPELIN-16

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-zeppelin/pull/16.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #16


          commit 3ab8c3c8fdd899166f9b13a8397118fbc2e92cc6
          Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
          Date: 2015-03-30T03:58:40Z

          ZEPPELIN-11 work in progress patch for hive interpreter

          commit 7ca31341ad8ea05a8e6f36abc67aa1e2b3ea92c5
          Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
          Date: 2015-03-31T04:48:23Z

          ZEPPELIN-11
          1. Fixed indentation issues
          2. Made hive and hadoop versions configurable
          3. Added unit tests

          commit 1d76dbd933d21b09e4fb6d223415aace0990c8f6
          Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
          Date: 2015-03-31T06:40:45Z

          ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported

          commit f85e690c779cae58335387a8bd934b800d93031c
          Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
          Date: 2015-03-31T06:41:54Z

          Fixed style check


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user RamVenkatesh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/16 ZEPPELIN-16 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RamVenkatesh/incubator-zeppelin ZEPPELIN-16 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 3ab8c3c8fdd899166f9b13a8397118fbc2e92cc6 Author: Ram Venkatesh <rvenkatesh@hortonworks.com> Date: 2015-03-30T03:58:40Z ZEPPELIN-11 work in progress patch for hive interpreter commit 7ca31341ad8ea05a8e6f36abc67aa1e2b3ea92c5 Author: Ram Venkatesh <rvenkatesh@hortonworks.com> Date: 2015-03-31T04:48:23Z ZEPPELIN-11 1. Fixed indentation issues 2. Made hive and hadoop versions configurable 3. Added unit tests commit 1d76dbd933d21b09e4fb6d223415aace0990c8f6 Author: Ram Venkatesh <rvenkatesh@hortonworks.com> Date: 2015-03-31T06:40:45Z ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported commit f85e690c779cae58335387a8bd934b800d93031c Author: Ram Venkatesh <rvenkatesh@hortonworks.com> Date: 2015-03-31T06:41:54Z Fixed style check
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user RamVenkatesh closed the pull request at:

          https://github.com/apache/incubator-zeppelin/pull/16

          Show
          githubbot ASF GitHub Bot added a comment - Github user RamVenkatesh closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/16
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user RamVenkatesh opened a pull request:

          https://github.com/apache/incubator-zeppelin/pull/17

          ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported

          ... reported

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/RamVenkatesh/incubator-zeppelin ZEPPELIN-16

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-zeppelin/pull/17.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #17


          commit 80793c4e1101f4c9579a8298187ea084c2714cbd
          Author: Ram Venkatesh <rvenkatesh@hortonworks.com>
          Date: 2015-03-31T06:51:04Z

          ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user RamVenkatesh opened a pull request: https://github.com/apache/incubator-zeppelin/pull/17 ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported ... reported You can merge this pull request into a Git repository by running: $ git pull https://github.com/RamVenkatesh/incubator-zeppelin ZEPPELIN-16 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 80793c4e1101f4c9579a8298187ea084c2714cbd Author: Ram Venkatesh <rvenkatesh@hortonworks.com> Date: 2015-03-31T06:51:04Z ZEPPELIN-16 Some failures from Spark and SparkSql note execution are not reported
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user felixcheung commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88191513

          LGTM!

          Show
          githubbot ASF GitHub Bot added a comment - Github user felixcheung commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88191513 LGTM!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user RamVenkatesh commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88570450

          @felixcheung thank you for the review. If there are no other comments, can we please get this checked in? Many of our users are running into this issue.

          Show
          githubbot ASF GitHub Bot added a comment - Github user RamVenkatesh commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88570450 @felixcheung thank you for the review. If there are no other comments, can we please get this checked in? Many of our users are running into this issue.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user Leemoonsoo commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88663040

          Thanks for the cool fix!
          I've tested and LGTM.
          merging it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user Leemoonsoo commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88663040 Thanks for the cool fix! I've tested and LGTM. merging it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-zeppelin/pull/17

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/17
          Hide
          moon Lee moon soo added a comment -
          Show
          moon Lee moon soo added a comment - issue resolved by https://github.com/apache/incubator-zeppelin/pull/17
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user swkimme commented on the pull request:

          https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88674063

          Awesome!

          Show
          githubbot ASF GitHub Bot added a comment - Github user swkimme commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/17#issuecomment-88674063 Awesome!

            People

            • Assignee:
              venkateshrin Ram Venkatesh
              Reporter:
              venkateshrin Ram Venkatesh
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development