[YUNIKORN-832] Updating config can't remove partition

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.1
• Labels: pull-request-available
• Target Version: 0.12.1
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 01/Sep/21 18:27
• Updated: 21/Jan/22 21:48
• Resolved: 27/Sep/21 10:48

Description

All functions in `partition_manager` are using pass-by-value so setting the `stop` flag to true can't terminate other threads.

func (manager partitionManager) Stop() {
 manager.stop = true
}

Also, the thread used to cleanup expired app can't be stopped quickly after removing partition because it needs to sleep for 24 hours.

func (manager partitionManager) cleanupExpiredApps() {
	for {
		if manager.stop {
			break
		}
		manager.pc.cleanupExpiredApps()
		time.Sleep(appRemovalInterval)
	}
}

Issue Links

• fixes: YUNIKORN-385 Deleted partitions are not deleted from core
• links to: GitHub Pull Request #319