[YUNIKORN-806] Refactor busy loop of PlaceholderManager#start

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.12.1
• Labels: pull-request-available
• Target Version: 0.12.1
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 19/Aug/21 07:05
• Updated: 21/Jan/22 21:48
• Resolved: 20/Aug/21 09:47

Description

The busy loop can be refactor by select timeout.

		// clean orphan placeholders approximately every 5 seconds, check for stop every 100 milliseconds
		for {
			mgr.cleanOrphanPlaceholders()
			for i := 0; i < 50; i++ {
				select {
				case <-mgr.stopChan:
					mgr.setRunning(false)
					log.Logger().Info("PlaceholderManager has been stopped")
					return
				default:
					time.Sleep(100 * time.Millisecond)
				}
			}
		}

Issue Links

• links to: GitHub Pull Request #295