[YUNIKORN-663] Improve log messages in node.go

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11
• Component/s: shim - kubernetes
• Labels: newbie pull-request-available
• Target Version: 0.11
• Assignee: Chen Yu Teng
• Reporter: Kinga Marton
• Created: 03/May/21 12:37
• Updated: 21/Jan/22 21:48
• Resolved: 15/May/21 20:53

Description

There are some places when the log message did not have any identity information, for example when the occupied resources are set (https://github.com/apache/incubator-yunikorn-k8shim/blob/master/pkg/cache/node.go#L115) we log a message that this is happening, but there is no node ID mentioned, so this message in this form is totally useless.

An another example is when an allocation added: (https://github.com/apache/incubator-yunikorn-k8shim/blob/master/pkg/cache/node.go#L107)

We should revisit this log messages and extend them with some identification related information. At least with the nodeID.

 

Issue Links

• links to: GitHub Pull Request #261
• links to: PR