[YUNIKORN-601] KubeClient mock does not allow failure tests

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: shim - kubernetes, test - unit
• Labels: pull-request-available
• Assignee: Ted Lin
• Reporter: Wilfred Spiegelenburg
• Created: 25/Mar/21 01:54
• Updated: 04/May/22 23:52
• Resolved: 14/Apr/22 02:48

Description

The way the NewKubeClientMock() works is to setup functions fo all actions that always succeed. That prevents any error handling to be tested in the unit tests that require failure for a delete, update or add.

We should be able to test failure paths also when using the mock.

The fact that we cannot test failure paths with the mock allowed YUNIKORN-600 to go undetected.

Issue Links

• is related to: YUNIKORN-600 Placeholder manager needs to initialize the orphan pods map
• links to: GitHub Pull Request #395
• links to: GitHub Pull Request #395