[YUNIKORN-2980] DaemonSet preemption: don't flood the logs if victim selection fails

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0, 1.6.1
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.7.0, 1.6.1
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 19/Nov/24 12:25
• Updated: 20/Nov/24 23:19
• Resolved: 20/Nov/24 23:19

Description

If we can't find a proper victim for a DaemonSet pod, we constaly print the following to the console in every scheduling cycle:

log.Log(log.SchedApplication).Info("Triggering preemption process for daemon set ask",
		zap.String("ds allocation key", ask.GetAllocationKey()))
[...]
log.Log(log.SchedApplication).Warn("Problem in finding the victims for preempting resources to meet required ask requirements",
		zap.String("ds allocation key", ask.GetAllocationKey()),
		zap.String("node id", reserve.nodeID))

Since we attempt to schedule in every 100ms, this is logged at least 10 times in every second.

Suggestion: do the preemption silently and only log if it has succeeded, just like regular preemption. Otherwise, use Allocation.LogAllocationFailure() which we already do for a variety of things.

Issue Links

• links to: GitHub Pull Request #998