[YUNIKORN-2789] Queue internalGetMax should use permissive calculator

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - common
• Labels: pull-request-available
• Target Version: 1.6.0
• Assignee: Wilfred Spiegelenburg
• Reporter: Wilfred Spiegelenburg
• Created: 07/Aug/24 05:56
• Updated: 12/Aug/24 19:53
• Resolved: 12/Aug/24 19:53

Description

We have documented for queue resources that:

Resources that are not specified in the list are not limited, for max resources, or guaranteed in the case of guaranteed resources.

However in the implementation on the queue, internalGetMax, we call resources.ComponentWiseMin(). This returns 0 values for each type that is not defined in the two resources passed in. That does not line up.

Example for getting the maximum resources of a queue using GetMaxQueueSet what I would expect based on the documentation:

 

parent: max{memory: 100G}
parent.child: max{vcore: 100}
  => result child max{memory: 100G, vcore: 100}

 

 

currently we get:

parent: max{memory: 100G}
parent.child: max{vcore: 100}
  => result child max{memory: 0, vcore: 0}

Similar when we add the root and call GetMaxResource:

root: max{memory: 100G, vcore: 200}
root.parent: max{vcore: 100}
root.parent.child: max{nvidia.com/gpu: 10}
   => result parent max{memory: 0, vcore: 100}
   => result child max{memory: 0, vcore: 0, nvidia.com/gpu: 0}

The fact that the resource type does not exist, even in the root, should not mean a zero set. The nodes that expose the specific resource might not have been registered or scaled up yet.

 

Issue Links

• is related to: YUNIKORN-2678 Fair queue sorting is inconsistent
• links to: GitHub Pull Request #936