[YUNIKORN-2788] Node.AddAllocation() isn't error checked - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.6.0
Component/s: None
Labels:
- pull-request-available

Target Version:

1.6.0

Description

The AddAllocation() method is sometimes called in contexts where the allocation can fail, and others where it should not. This leads to silent corruption of values in certain cases. To fix this, we should split this method into TryAddAllocation(), using the existing semantics, and a new AddAllocation() method which cannot fail.