[YUNIKORN-2184] k8shim: fix goconst linter issues

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: shim - kubernetes
• Labels: newbie pull-request-available
• Target Version: 1.5.0
• Assignee: JiaChi Wang
• Reporter: Wilfred Spiegelenburg
• Created: 23/Nov/23 00:47
• Updated: 20/Mar/24 14:32
• Resolved: 25/Nov/23 01:53

Description

Fix existing goconst linter issues:

pkg/admission/webhook_manager.go:385:21: string `yunikorn` has 3 occurrences, but such constant `yunikornPod` already exists (goconst)
    if !ok || value != "yunikorn" {
                       ^
pkg/cache/context_test.go:245:12: string `app00002` has 3 occurrences, make it a constant (goconst)
    appID2 := "app00002"
              ^
pkg/cache/application_test.go:166:11: string `app-test-001` has 6 occurrences, but such constant `appID` already exists (goconst)
    appID := "app-test-001"
             ^
pkg/cache/application_test.go:447:10: string `testUUID001` has 3 occurrences, make it a constant (goconst)
    UUID := "testUUID001"
            ^
pkg/cache/application.go:104:34: string `no transition` has 3 occurrences, make it a constant (goconst)
    if err != nil && err.Error() != "no transition" {
                                    ^
pkg/cache/application_test.go:533:11: string `app00001` has 5 occurrences, but such constant `appID` already exists (goconst)
    appID := "app00001"
             ^

Issue Links

• links to: GitHub Pull Request #736