[YUNIKORN-2157] Data race in TestStoreWithLimitedSize

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: core - scheduler, test - unit
• Labels: pull-request-available
• Target Version: 1.5.0
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 15/Nov/23 15:21
• Updated: 20/Mar/24 14:32
• Resolved: 17/Nov/23 18:06

Description

We found a race condition in our internal build env:

 ==================
 WARNING: DATA RACE
 Read at 0x0000013045a0 by goroutine 32:
   github.com/apache/yunikorn-core/pkg/events.(*EventStore).CollectEvents()
       /redacted/yunikorn-core/pkg/events/event_store.go:67 +0x1a8
   github.com/apache/yunikorn-core/pkg/events.(*EventPublisher).StartService.func1()
       /redacted/yunikorn-core/pkg/events/event_publisher.go:55 +0xd1
 
 Previous write at 0x0000013045a0 by goroutine 44:
   github.com/apache/yunikorn-core/pkg/events.TestStoreWithLimitedSize.func1()
       /redacted/yunikorn-core/pkg/events/event_store_test.go:59 +0x24
   runtime.deferreturn()
       /redacted/common/go/src/runtime/panic.go:477 +0x30
   testing.tRunner()
       /redacted/common/go/src/testing/testing.go:1595 +0x238
   testing.(*T).Run.func1()
       /redacted/common/go/src/testing/testing.go:1648 +0x44
 
 Goroutine 32 (running) created at:
   github.com/apache/yunikorn-core/pkg/events.(*EventPublisher).StartService()
       /redacted/yunikorn-core/pkg/events/event_publisher.go:50 +0xdc
   github.com/apache/yunikorn-core/pkg/events.TestPublisherSendsEvent()
       /redacted/yunikorn-core/pkg/events/event_publisher_test.go:122 +0x224
   testing.tRunner()
       /redacted/common/go/src/testing/testing.go:1595 +0x238
   testing.(*T).Run.func1()
       /redacted/common/go/src/testing/testing.go:1648 +0x44
 
 Goroutine 44 (finished) created at:
   testing.(*T).Run()
       /redacted/common/go/src/testing/testing.go:1648 +0x82a
   testing.runTests.func1()
       /redacted/common/go/src/testing/testing.go:2054 +0x84
   testing.tRunner()
       /redacted/common/go/src/testing/testing.go:1595 +0x238
   testing.runTests()
       /redacted/common/go/src/testing/testing.go:2052 +0x896
   testing.(*M).Run()
       /redacted/common/go/src/testing/testing.go:1925 +0xb57
   main.main()
       _testmain.go:121 +0x2e4

Issue Links

• links to: GitHub Pull Request #716