[YUNIKORN-1905] instance type cleanup

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: core - scheduler
• Labels: newbie pull-request-available
• Target Version: 1.4.0
• Assignee: PoAn Yang
• Reporter: Wilfred Spiegelenburg
• Created: 08/Aug/23 09:11
• Updated: 20/Nov/23 16:42
• Resolved: 08/Aug/23 18:53

Description

While reviewing YUNIKORN-1888 I noticed that the changes for YUNIKORN-1889 can be pushed through even further.

We still pull the instanceType in multiple locations and in the end overwrite it in the partition.allocate call. That is unneeded work we do in multiple places in the code.

We should clean up further and rely on the partition to always set the instanceType for an allocation. Remove it from the call NewAllocation which means we can remove it from NewAllocationFromSI. 

The partition allocate call is however not used when we initialise the system as we need to bypass certain checks for allocations that are already running. This means one extra location in the partition to handle that after YUNIKORN-1888 is done.

Issue Links

• is a child of: YUNIKORN-1889 Remove instanceType from scheduling cycle
• links to: GitHub Pull Request #615