[YUNIKORN-1764] Don't copy resource object in Node.preAllocateCheck()

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 23/May/23 23:31
• Updated: 20/Jun/23 14:41
• Resolved: 24/May/23 02:50

Description

The method Resource.Clone() shows up quite often in various heap profiles which were captured on busy clusters (see screenshot).

One of the call sites of this method is Node.preAllocateCheck() which calls this method in the scheduling cycle very often:

	// check if resources are available
	available := sn.GetAvailableResource()
	// returns true/false based on if the request fits in what we have calculated
	return available.FitInMaxUndef(res)

GetAvailableResource() returns the copy of the underlying resource object. However, cloning is not necessary. Two approaches are possible:

1. since this code is inside the Node object, we can access sn.availableResource without cloning by simply acquiring the read lock
2. add a new method which receives a Resource object, then performs the fit-no fit check without copying

Issue Links

• links to: GitHub Pull Request #551