[YUNIKORN-1653] Use enum instead of defined values for tri-state

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: shim - kubernetes
• Labels: newbie pull-request-available
• Target Version: 1.3.0
• Assignee: Hsuan Zong Wu
• Reporter: Wilfred Spiegelenburg
• Created: 24/Mar/23 02:24
• Updated: 20/Jun/23 14:41
• Resolved: 11/May/23 20:46

Description

In the admission controller we have a tri-state that uses an integer as the underlying values. We should move to a iota that represents the same three values for clarity:

type triState int

const (
   UNSET triState = iota - 1
   FALSE
   TRUE
) 

Replace all the coded values with the triState values, store the triState and return it from function calls.

Issue Links

• is related to: YUNIKORN-1647 Dynamic namespace support in Admission controller
• links to: GitHub Pull Request #578