[YUNIKORN-1650] Add setting for default queue in admission controller

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: shim - kubernetes
• Labels: pull-request-available
• Target Version: 1.3.0
• Assignee: Mit Desai
• Reporter: Mit Desai
• Created: 22/Mar/23 21:19
• Updated: 13/Jul/23 14:45
• Resolved: 23/May/23 19:53

Description

If the queue name is not defined during the job submission, YuniKorn admission controller will add a default queue to the pod labels.

When provided placement rule is defined, along with other placement rules, it is possible that only provided placement rule is executed and no other rule is exercised.

In the following scenario, when there are 3 placement rules defined,
placementrules:
        - name: provided
        - name: tag
        - name: fixed

The applications will be placed in the right queue, following the provided rule if the queue is defined during job submission. If the queue is not defined during job submission, admission controller will add a default queue name. This will again trigger the provided rule as the queue name will be found in the pod labels during placement rules execution. As a result, tag and fixed rules will never be executed and all the apps that do not have a queue defined will end up getting placed in the default queue.

To solve this, we should have a toggle in the admission controller configs whether to add the default queue to or not. Whenever such placement rules are setup, admission controller should be configured to skip adding the default queue name.

Issue Links

• is fixed by: YUNIKORN-1856 Pod creation fails in certain cases when generateUniqueAppId is enabled
• links to: GitHub Pull Request #597

Sub-Tasks

• Documentation: Toggle for adding default queue in admission controller: Closed