[YUNIKORN-1564] Constants for node attributes are not consistent in scheduler interface and shim

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: scheduler-interface, shim - kubernetes
• Labels: pull-request-available
• Target Version: 1.3.0
• Assignee: Qi Zhu
• Reporter: Qi Zhu
• Created: 07/Feb/23 09:13
• Updated: 23/Feb/23 13:57
• Resolved: 13/Feb/23 03:18

Description

Constants for node attributes are not consistent in scheduler interface and shim:

In scheduler interface and core side usage, we use prefix "si":

// Constants for node attributes
const (
   ARCH                = "si/arch"
   HostName            = "si/hostname"
   RackName            = "si/rackname"
   OS                  = "si/os"
   InstanceType        = "si/instance-type"
   FailureDomainZone   = "si/zone"
   FailureDomainRegion = "si/region"
   LocalImages         = "si/local-images"
   NodePartition       = "si/node-partition"
) 

But in shim we pass the prefix "si.io":

// Cluster
const DefaultNodeAttributeHostNameKey = "si.io/hostname"
const DefaultNodeAttributeRackNameKey = "si.io/rackname"
const DefaultNodeAttributeNodeLabelsKey = "si.io/nodelabels" 

 

Issue Links

• is related to: YUNIKORN-1560 Remove nodename and rackname from node attributes
• links to: GitHub Pull Request #523