[YUNIKORN-1525] data race: TestTryReserve

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: shim - kubernetes, test - unit
• Labels: pull-request-available
• Target Version: 1.2.0
• Assignee: Peter Bacsko
• Reporter: Wilfred Spiegelenburg
• Created: 02/Jan/23 22:52
• Updated: 07/Feb/23 22:33
• Resolved: 25/Jan/23 05:26

Description

 

2022-12-30T10:23:38.762Z    ERROR    cache/context.go:1022    failed to handle application event    {"reason": "application not exist"}
github.com/apache/yunikorn-k8shim/pkg/cache.(*Context).ApplicationEventHandler.func1
    /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/context.go:1022
github.com/apache/yunikorn-k8shim/pkg/dispatcher.Start.func1
    /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/dispatcher/dispatcher.go:197
==================
WARNING: DATA RACE
Write at 0x00c0000cdf80 by goroutine 51:
  runtime.mapassign_faststr()
      /opt/hostedtoolcache/go/1.18.9/x64/src/runtime/map_faststr.go:203 +0x0
  github.com/apache/yunikorn-k8shim/pkg/cache.TestTryReserve()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/application_test.go:722 +0x3ec
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1486 +0x47
Previous read at 0x00c0000cdf80 by goroutine 54:
  runtime.mapaccess2_faststr()
      /opt/hostedtoolcache/go/1.18.9/x64/src/runtime/map_faststr.go:108 +0x0
  github.com/apache/yunikorn-k8shim/pkg/cache.(*Context).getApplication()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/context.go:768 +0x6e
  github.com/apache/yunikorn-k8shim/pkg/cache.(*Context).GetApplication()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/context.go:764 +0xf2
  github.com/apache/yunikorn-k8shim/pkg/cache.(*Context).ApplicationEventHandler.func1()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/context.go:1020 +0xc8
  github.com/apache/yunikorn-k8shim/pkg/dispatcher.Start.func1()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/dispatcher/dispatcher.go:197 +0x2eb
Goroutine 51 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1486 +0x724
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1839 +0x99
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1719 +0xa71
  main.main()
      _testmain.go:355 +0x3a9
Goroutine 54 (running) created at:
  github.com/apache/yunikorn-k8shim/pkg/dispatcher.Start()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/dispatcher/dispatcher.go:187 +0x150
  github.com/apache/yunikorn-k8shim/pkg/cache.TestTryReserve()
      /home/runner/work/yunikorn-k8shim/yunikorn-k8shim/pkg/cache/application_test.go:705 +0x64
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.9/x64/src/testing/testing.go:1486 +0x47
==================

 

Issue Links

• links to: GitHub Pull Request #512