[YUNIKORN-1490] Only copy pull secrets when gang scheduling

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: shim - kubernetes
• Labels: newbie
• Assignee: Qi Zhu
• Reporter: Wilfred Spiegelenburg
• Created: 21/Dec/22 08:57
• Updated: 22/Dec/22 10:16

Description

In the current setup we copy the image pull secrets from a pod and add it to the tags. We do this always, without thinking if we need them.

We should only copy the secrets if the pod has gang scheduling annotations and gang scheduling is enabled. That is the only case in which we need the secrets as we need to propagate them to the placeholders.

We should also not add them to the tags but keep them in a seperate part of the metadata as we do not want them in the core which is where they end up now as part of the tags.