[YUNIKORN-1476] The nodes with negative resources health check prints partitions instead of nodes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.2.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Assignee: Eli Schiff
• Reporter: Eli Schiff
• Created: 15/Dec/22 21:45
• Updated: 07/Feb/23 22:33
• Resolved: 19/Dec/22 06:57

Description

The nodes with negative resources health check has a typo where it correctly checks if any nodes have negative resources, but the value it prints in the log message is wrong. It instead prints partitions with negative resources. It looks like a simple copy paste typo.

 

For example:

In the health check logs I was seeing 

{"Name":"Negative resources","Succeeded":false,"Description":"Check for negative resources in the nodes","DiagnosisMessage":"Nodes with negative resources: []"}

If this log is saying there are nodes with negative resources, I would expect the array at the end to not be empty.

 

I have a fix for this here https://github.com/apache/yunikorn-core/pull/482

Issue Links

• links to: GitHub Pull Request #482