[YUNIKORN-1164] Fix inconsistent lock behavior in application.go

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.0.0
• Assignee: Craig Condit
• Reporter: Craig Condit
• Created: 30/Mar/22 16:24
• Updated: 04/May/22 23:52
• Resolved: 04/Apr/22 17:01

Description

The Application object in pkg/scheduler/objects/application.go has inconsistent locking in several places:

• getPlaceholderAllocations() accesses the allocations map unlocked which might cause issues.

• Usages of clearStateTimer() also should be checked.

• HandleApplicationEvent() and OnStateChange() assume the lock is held. However, timeoutStateTimer() calls HandleApplicationEvent() with no lock held.

We should look for any other potential issues here as well.

Issue Links

• links to: GitHub Pull Request #399