[YUNIKORN-1124] Avoid passing empty nodeAttributes in UpdateNode request

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Labels: pull-request-available
• Target Version: 1.0.0
• Assignee: Manikandan R
• Reporter: Manikandan R
• Created: 16/Mar/22 16:28
• Updated: 11/Dec/23 14:49
• Resolved: 18/Mar/22 01:48

Description

YUNIKORN-1123 had fixed YUNIKORN-1090 by passing empty nodeAttributes in UpdateNode request. But it is better to handle this empty checks in core itself and avoid passing empty attributes map from shim side. In addition, need to assess the following:

 

1. Does core uses OccupiedResource and labels attributes being sent as part of Create NodeRequest from shim?
2. By any chance, Does shim need to pass yunikorn.apache.org/nodeType attribute to core? Anyway, need to make it as constant

Issue Links

• causes: YUNIKORN-1162 Recovery code does not update occupied resources on node
• Discovered while testing: YUNIKORN-1090 remove common.Node from the shim
• is caused by: YUNIKORN-802 Supports to assign nodes to non-default partition
• relates to: YUNIKORN-2263 Initialize node attributes if it's nil
• links to: GitHub Pull Request #387
• links to: GitHub Pull Request #390
• links to: GitHub Pull Request #666