[YUNIKORN-1123] UpdateNode may cause the scheduler to crash

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Assignee: Manikandan R
• Reporter: Chaoran Yu
• Created: 16/Mar/22 05:55
• Updated: 04/May/22 23:52
• Resolved: 16/Mar/22 14:07

Description

https://github.com/apache/incubator-yunikorn-core/blob/master/pkg/rmproxy/rmproxy.go#L369 may cause the scheduler to crash because the node.Attributes map could be uninitialized. 

Example:

 

2022-03-16T05:22:46.077Z INFO cache/nodes.go:216 report updated nodes to scheduler {"request": "nodes:<nodeID:\"ip-172-19-185-239.us-west-2.compute.internal\" action:DECOMISSION > rmID:\"mycluster\" "}
panic: assignment to entry in nil map
goroutine 395199 [running]:
github.com/apache/incubator-yunikorn-core/pkg/rmproxy.(*RMProxy).UpdateNode.func1(0xc02d9fa320, 0xc000300000)
 /go/pkg/mod/github.com/apache/incubator-yunikorn-core@v0.0.0-20220221055154-ff851af3b358/pkg/rmproxy/rmproxy.go:368 +0x11d
created by github.com/apache/incubator-yunikorn-core/pkg/rmproxy.(*RMProxy).UpdateNode
 /go/pkg/mod/github.com/apache/incubator-yunikorn-core@v0.0.0-20220221055154-ff851af3b358/pkg/rmproxy/rmproxy.go:364 +0x7a

 

Issue Links

• is caused by: YUNIKORN-1090 remove common.Node from the shim
• links to: GitHub Pull Request #387