Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.0-incubating-M1, Incubation
    • Fix Version/s: v1.0-incubating-M1, Incubation
    • Component/s: None
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      The
      code currently contains the following copyright statement:

      // **********************************************************************
      //
      // Copyright (c) 2005-2006
      // IONA Technologies PLC
      // Dublin, Ireland and Waltham, MA, USA
      //
      // All Rights Reserved
      //
      // Licensed to apache under Apache 2.0 License - 2006
      // **********************************************************************

      I don't see a problem with the IONA copyright still being there, but
      this copyright refers to IONA granting rights to Apache. Shouldn't this
      copyright statement also include the standard apache statement about
      what rights Apache is granting to use the code:

      /**
      *

      • Copyright 2006 The Apache Software Foundation
        *
      • Licensed under the Apache License, Version 2.0 (the "License");
      • you may not use this file except in compliance with the License.
      • You may obtain a copy of the License at
        *
      • http://www.apache.org/licenses/LICENSE-2.0
        *
      • Unless required by applicable law or agreed to in writing, software
      • distributed under the License is distributed on an "AS IS" BASIS,
      • WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
      • See the License for the specific language governing permissions and
      • limitations under the License.
        */

      Also, I'm assuming new files introduced into this code tree (i.e., not
      part of the original IONA contribution) should only have the Apache
      copyright statement.
      Is there some correction required here?

      Rick

      1. idl.licenses.diff
        30 kB
        Alexey Petrenko
      2. yoko.licences.diff.gz
        85 kB
        Alexey Petrenko
      3. yoko.noiona.licences.diff.gz
        94 kB
        Alexey Petrenko

        Activity

        Hide
        Alexey Petrenko added a comment -

        Apache headers are inserted before IONA copyrights in java files

        Show
        Alexey Petrenko added a comment - Apache headers are inserted before IONA copyrights in java files
        Hide
        Alan Cabrera added a comment -

        IIUC, the IONA copyrights have to be totally removed.

        Show
        Alan Cabrera added a comment - IIUC, the IONA copyrights have to be totally removed.
        Hide
        Alexey Petrenko added a comment -

        The new patch REMOVES Iona copyright headers and inserts Apacha copyright headers.

        Show
        Alexey Petrenko added a comment - The new patch REMOVES Iona copyright headers and inserts Apacha copyright headers.
        Hide
        Balaji Ravi added a comment -

        Applied Alexey Pretrenko's patch to update the copyrights in the core & yoko-spec-corba modules. Also added iona's copyright as a separate file.

        Show
        Balaji Ravi added a comment - Applied Alexey Pretrenko's patch to update the copyrights in the core & yoko-spec-corba modules. Also added iona's copyright as a separate file.
        Hide
        Alan Cabrera added a comment -

        I still see a lot of old copyrights around.

        Show
        Alan Cabrera added a comment - I still see a lot of old copyrights around.
        Hide
        Alexey Petrenko added a comment -

        As I specified in the attachment comment my patch fixes only Java files... I was affraid that patch for everything will be too large

        I've checked all the sources now and it seems we have 2 types of files with remaining IONA copyrights:
        1. runtests - old scripts for running tests. Not working now. I think they should be removed.
        2. *.idl files - I'll prepare a patch for them.

        There are also a couple of COPYRIGHT files with IONA copyrights.

        Here is a list of runtest files:
        ./core/src/test/java/test/codesets/runtest
        ./core/src/test/java/test/iiopplugin/runtest
        ./core/src/test/java/test/ins/runtest
        ./core/src/test/java/test/local/runtest
        ./core/src/test/java/test/main/runtest
        ./core/src/test/java/test/obv/runtest
        ./core/src/test/java/test/pi/runtest
        ./core/src/test/java/test/poa/runtest
        ./core/src/test/java/test/retry/runtest
        ./core/src/test/java/test/tnaming/runtest
        ./core/src/test/java/test/types/runtest
        ./core/target/test-classes/test/codesets/runtest
        ./core/target/test-classes/test/iiopplugin/runtest
        ./core/target/test-classes/test/ins/runtest
        ./core/target/test-classes/test/local/runtest
        ./core/target/test-classes/test/main/runtest
        ./core/target/test-classes/test/obv/runtest
        ./core/target/test-classes/test/pi/runtest
        ./core/target/test-classes/test/poa/runtest
        ./core/target/test-classes/test/retry/runtest
        ./core/target/test-classes/test/tnaming/runtest
        ./core/target/test-classes/test/types/runtest

        Show
        Alexey Petrenko added a comment - As I specified in the attachment comment my patch fixes only Java files... I was affraid that patch for everything will be too large I've checked all the sources now and it seems we have 2 types of files with remaining IONA copyrights: 1. runtests - old scripts for running tests. Not working now. I think they should be removed. 2. *.idl files - I'll prepare a patch for them. There are also a couple of COPYRIGHT files with IONA copyrights. Here is a list of runtest files: ./core/src/test/java/test/codesets/runtest ./core/src/test/java/test/iiopplugin/runtest ./core/src/test/java/test/ins/runtest ./core/src/test/java/test/local/runtest ./core/src/test/java/test/main/runtest ./core/src/test/java/test/obv/runtest ./core/src/test/java/test/pi/runtest ./core/src/test/java/test/poa/runtest ./core/src/test/java/test/retry/runtest ./core/src/test/java/test/tnaming/runtest ./core/src/test/java/test/types/runtest ./core/target/test-classes/test/codesets/runtest ./core/target/test-classes/test/iiopplugin/runtest ./core/target/test-classes/test/ins/runtest ./core/target/test-classes/test/local/runtest ./core/target/test-classes/test/main/runtest ./core/target/test-classes/test/obv/runtest ./core/target/test-classes/test/pi/runtest ./core/target/test-classes/test/poa/runtest ./core/target/test-classes/test/retry/runtest ./core/target/test-classes/test/tnaming/runtest ./core/target/test-classes/test/types/runtest
        Hide
        Alexey Petrenko added a comment -

        This diff substitutes licenses in the idl files.

        I can not find IONA copyrights any more. Except of two COPYRIGHT files and runtest scripts...

        Show
        Alexey Petrenko added a comment - This diff substitutes licenses in the idl files. I can not find IONA copyrights any more. Except of two COPYRIGHT files and runtest scripts...
        Hide
        Balaji Ravi added a comment -

        Applied the patch & also updated the runtest scripts...

        Show
        Balaji Ravi added a comment - Applied the patch & also updated the runtest scripts...
        Hide
        Alexey Petrenko added a comment -

        Runtest scripts seems not working... So I do not see the reason to keep them.

        Show
        Alexey Petrenko added a comment - Runtest scripts seems not working... So I do not see the reason to keep them.
        Hide
        Alexey Petrenko added a comment -

        Or we need to make them working....

        Show
        Alexey Petrenko added a comment - Or we need to make them working....
        Hide
        Alan Cabrera added a comment -

        Must be completed before milestone release.

        Show
        Alan Cabrera added a comment - Must be completed before milestone release.
        Hide
        Alan Cabrera added a comment -

        Thanks Balaji!

        Show
        Alan Cabrera added a comment - Thanks Balaji!
        Hide
        Alan Cabrera added a comment -

        Released.

        Show
        Alan Cabrera added a comment - Released.

          People

          • Assignee:
            Balaji Ravi
            Reporter:
            Adi Sakala
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development