[YETUS-873] Error on unprocessed options/parameters

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Component/s: Precommit

Release Note

<!-- markdown -->
Users:

precommit's commands (docker-cleanup, qbt, smart-apply-patch, test-patch) will now exit with an error if they are given a double-dashed option that is unknown. Using `--ignore-unknown-options=true` option will return to the previous behavior. Non double-dashed parameters continue to be considered the patch location.

This option will be removed in a future release.

Developers:

This patch adds the `delete_parameter` routine. It should be called to remove an option from the variable that is being used to track which parameters have been processed. The internals of this tracking are still very much in flux and may change in the future.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 04/May/19 16:42
• Updated: 15/May/19 20:28
• Resolved: 13/May/19 17:24

Description

Given how frequently we've been eliminating some parameters lately as we make things more automatic and/or pushed to be external (e.g., pylintrc vs. CLI options), it is probably a good idea to start getting stricter on what options are being passed on the CLI.

Issue Links

• contains: YETUS-636 Test Patch should track consumed cli options and note unused ones
• links to: GitHub Pull Request #53