Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-484

Fixing bug when checkstyle runs on multiple modules

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.3.0, 0.4.0, 0.5.0
    • 0.5.0
    • Precommit
    • None

    Description

      When trying to run checkstyle plugin with a patch which changes 2 modules the checkstyle changes directory to the first modules directory twice, so no change file is generated for the second directory.

      See:

      ============================================================================
      ============================================================================
                                     checkstyle: 
      ============================================================================
      ============================================================================
      
      
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Start clock
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: branch checkstyle
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: clear queue
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: enqueue ql -DskipTests -Pitests
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Personality: enqueue serde -DskipTests -Pitests
      [Mon Jan 30 16:19:57 CET 2017 DEBUG]: Start clock
      cd /Users/petervary/dev/upstream/hive/ql
      mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch > /private/tmp/yetus-16782.23776/maven-branch-checkstyle-ql.txt 2>&1
      [Mon Jan 30 16:20:40 CET 2017 DEBUG]: Stop clock
      [Mon Jan 30 16:20:40 CET 2017 DEBUG]: Start clock
      cd /Users/petervary/dev/upstream/hive/ql
      mvn checkstyle:checkstyle -Dcheckstyle.consoleOutput=true -DskipTests -Pitests -Ptest-patch > /private/tmp/yetus-16782.23776/maven-branch-checkstyle-serde.txt 2>&1
      

      My guess is there is a missing parameter in checkstyle.sh when calling {{ buildtool_cwd}} without parameters.

      Adding the parameter resolves the directory change problem, and yetus generates the error report for both modules.

      Attachments

        1. YETUS-484.00.patch
          0.8 kB
          Peter Vary

        Activity

          People

            pvary Peter Vary
            pvary Peter Vary
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: