Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-464

test-patch silently continues when USER_PLUGIN_DIR doesn't exist

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: In Progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.4.0
    • Fix Version/s: None
    • Component/s: Precommit
    • Labels:
      None

      Description

      If one specifies a directory that does not exist in the --user-plugins argument, test-patch.sh will quietly ignore the directory.

      This was found when using a tilde ( ~ ) to attempt home directory expansion
      when testing a new plugin.

      Bash does not expand tilde's at the beginning of the line when quoted.

      Thoughts on resolving this:
      1) Should warn in the argument section in 01-common.sh if the directory does not exist. ( Not only for USER_PLUGIN_DIR butt for any of the other directories. )
      2) It might be possible to change yetus_abs to handle tilde expansion, and then use that code to expand the parameter. Of note is that yetus_abs is used to expand USER_PLUGIN_DIR in test-patch.sh
      3) If there are changes with the argument handling, it should be considered to check with the arguments to ensure that they are not being overwritten. ( This would only happen with user error, but makes debugging and understanding more difficult. )

      I will pull together a patch for #1, and reflect on #2/#3 further. Any comments, please add them to the Jira.

        Attachments

        1. YETUS-464.005.patch
          15 kB
          Casey Brotherton
        2. YETUS-464.003.patch
          5 kB
          Casey Brotherton
        3. YETUS-464.002.patch
          5 kB
          Casey Brotherton
        4. YETUS-464.001.patch
          4 kB
          Casey Brotherton

          Activity

            People

            • Assignee:
              caseyjbrotherton Casey Brotherton
              Reporter:
              caseyjbrotherton Casey Brotherton
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: