Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-267

use curl -L when given a patch URL

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.1.0
    • 0.2.0
    • Precommit
    • None

    Description

      I went to try out a local test-patch build using the patch from a GH pull request.

      test-patch --personality /usr/local/lib/yetus/lib/precommit/personality/accumulo.sh --branch=1.7 https://github.com/apache/accumulo/pull/61.patch --project=Accumulo
      

      This failed with an error message that Yetus couldn't apply the patch. This is because Github was sending a redirect, so the resulting patch Yetus tried to apply actually contained:

      <html><body>You are being <a href="https://patch-diff.githubusercontent.com/raw/apache/accumulo/pull/61.patch">redirected</a>.</body></html>
      

      It seems like a simple change to just default to curl -L instead of curl, but I'm surprised this wasn't encountered by anyone else before (so I present it with an air of caution).

      Attachments

        Issue Links

          Activity

            People

              elserj Josh Elser
              elserj Josh Elser
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: