[YETUS-1127] exclusions rework

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.14.0
• Fix Version/s: 0.14.0
• Component/s: Precommit

Release Note

<!-- markdown -->

Users:

Exclusion support has been modified to be slightly incompatible with previous releases:

* By default, `.yetus/excludes.txt` was supposed to have been read. However in previous releases it was ignored unless manually specified.
* `--excludes` has been restricted such that only files within the source repository, especially when running in `--docker` mode
* During a PR, the working set of changed files will now be completely recalculated, not just have additional files excluded.
* The `asflicense` plug-in will now honor the global excludes file unless `--asflicense-rat-globalexcludes=false` is passed.
* As a reminder, the excludes file needs to be regular expressions, not file globs. Therefore `.*` is the 'match everything' string.
* Several bugs with exclusion in various plug-ins have been simplified/cleaned up and should result in fewer corner-case issues.

Developers:

* `yetus_file_to_array` has been modified to additionally strip out lines that contain spaces in addition to empty lines and lines that begin with a comment.
* The private function `find_changed_dirs` and the `CHANGED_DIRS` variable has been removed. It has always been broken and nothing was known to use it.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 18/Oct/21 21:29
• Updated: 26/Oct/21 15:19
• Resolved: 25/Oct/21 14:03

Description

Working on detsecrets, it is very clear that exclusions needs to have some things re-thought. In particular:

a) comments in the file
b) exclusions file itself should probably be an exclusions ....
c) common code for routines to ignore files

Issue Links

• blocks: YETUS-1123 Add support for detect-secrets
• breaks: YETUS-1129 asflicense errors in yetus tree
• contains: YETUS-1083 find_changed_dirs is very very busted
• contains: YETUS-1114 golangci-lint grep exclude errors
• contains: YETUS-1098 .yetus/excludes.txt is not actually read by default
• links to: GitHub Pull Request #223