[YETUS-1072] Rework personalities and some plug-in handling

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Precommit

Release Note

<!-- markdown -->

Users:
* Precommit's bundled personalities have been removed as they are all out of date.
* Personalities will be loaded from `.yetus/personality.sh` by default.
* User-plugins will be loaded from`.yetus/plugins.d` by default.
* The `test-patch.d` directory has been renamed to `plugins.`
* `--project` can no longer be used to load a personality from a plugin directory.


Developers:
* BASEDIR is now absolute'd sooner.
* PERSONALITY and USER_PLUGIN_DIR will almost always have a value now.
* PERSONALITY is now guaranteed to load after plugins.
* `personality_modules` and `personality_file_tests` are no longer defined by default. Instead, plugins, core code, etc, (basically, anything not a personality) should call `personality_modules_wrapper` and `personality_file_tests_wrapper`. These functions will be redirect to the correct function.
* PROJECT_NAME_* is now honored for loading many of the personality-specific functions.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 04/Nov/20 00:31
• Updated: 02/Dec/20 02:54
• Resolved: 25/Nov/20 20:59

Description

a) Load personalities from $BASEDIR/.yetus/personality.sh
b) default user plugins to .yetus/plugins.d
c) Drop the old bundled personalities as no one is using them anymore
d) Move the yetus personality to the new location
e) support $PROJECT_NAME_(personalityfunction)
f) doc updates, as usual

Issue Links

• contains: YETUS-1071 By default, read $BASEDIR/.yetus/personality.sh
• is depended upon by: YETUS-1057 Remove findbugs support
• is related to: YETUS-1094 Load the personality file before loading plugins
• links to: GitHub Pull Request #196
• links to: GitHub Pull Request #207