Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-1017

Rework post-processing comparison to de-duplicate code

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Precommit
    • Labels:
      None
    • Release Note:
      Hide
      <!-- markdown -->
      Users:

      With this change, several plugins that did not generate line comments now do.

      Developers:

      The `generic_postlog_compare` / `generic_pre_handler` / `generic_post_handler` functions have been deprecated and replaced with `module_postlog_compare` / `module_pre_handler` / `module_post_handler` functions. A new `root_postlog_compare` has been added that works similarly to `module_postlog_compare` for plug-ins that do not support the MODULE system. Using `root_postlog_compare` makes writing plug-ins for static linters significantly easier. See the associated APIs for more information.
      Show
      <!-- markdown --> Users: With this change, several plugins that did not generate line comments now do. Developers: The `generic_postlog_compare` / `generic_pre_handler` / `generic_post_handler` functions have been deprecated and replaced with `module_postlog_compare` / `module_pre_handler` / `module_post_handler` functions. A new `root_postlog_compare` has been added that works similarly to `module_postlog_compare` for plug-ins that do not support the MODULE system. Using `root_postlog_compare` makes writing plug-ins for static linters significantly easier. See the associated APIs for more information.
    • Flags:
      Important

      Description

      Originally it was thought that many, many components would be MODULE based. That's turning out not to be the case. So a lot of the useful routines labeled 'generic' are stuck behind the MODULE system. It would be better to specifically rename 'generic' stuff to be 'module' and make new 'generic' routines that assume the root of the tree. Making this change will greatly improve the ability to quick add new static linters.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                aw Allen Wittenauer
                Reporter:
                aw Allen Wittenauer
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h