Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-1013

The --sentinel option in test-patch.sh should also set ROBOT to true

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Precommit
    • Labels:
      None

      Description

      For now it only set SENTINEL to true.

      And in core.d/docker.sh, in the docker_container_maintenance method, we have this at the beginning:

        if [[ "${ROBOT}" = false ]]; then
          return
        fi
      

      I think this will make us skip the docker cleanup step.

      In docker-cleanup.sh, we do have set ROBOT to true when parsing --sentinel but since in test-patch.sh, we have called delete_parameter so I'm afraid there is no way for docker-cleanup.sh to parse the parameter again?

        Attachments

          Activity

            People

            • Assignee:
              zhangduo Duo Zhang
              Reporter:
              zhangduo Duo Zhang

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                  Issue deployment