[YETUS-1013] The --sentinel option in test-patch.sh should also set ROBOT to true

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Precommit
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 02/Oct/20 09:23
• Updated: 02/Oct/20 14:15
• Resolved: 02/Oct/20 13:16

Description

For now it only set SENTINEL to true.

And in core.d/docker.sh, in the docker_container_maintenance method, we have this at the beginning:

  if [[ "${ROBOT}" = false ]]; then
    return
  fi

I think this will make us skip the docker cleanup step.

In docker-cleanup.sh, we do have set ROBOT to true when parsing --sentinel but since in test-patch.sh, we have called delete_parameter so I'm afraid there is no way for docker-cleanup.sh to parse the parameter again?

Issue Links

• links to: GitHub Pull Request #145