Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9998

Code cleanup in LeveldbConfigurationStore

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.2, 3.4.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Many things can be improved:

      • Field compactionTimer could be a local variable
      • Field versiondb should be camelcase
      • initDatabase is a very long method: Initialize db / versionDb should be in separate methods, split this method into smaller chunks
      • Remove TODOs
      • Remove duplicated code block in LeveldbConfigurationStore.CompactionTimerTask
      • Any other cleanup

        Attachments

        1. YARN-9998.001.patch
          10 kB
          Benjamin Teke
        2. YARN-9998.002.patch
          9 kB
          Benjamin Teke
        3. YARN-9998.branch-3.2.001.patch
          8 kB
          Benjamin Teke

        Issue Links

          Activity

            People

            • Assignee:
              bteke Benjamin Teke
              Reporter:
              snemeth Szilard Nemeth

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment