[YARN-9601] Potential NPE in ZookeeperFederationStateStore#getPoliciesConfigurations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: federation, yarn
• Assignee: hunshenshi
• Reporter: hunshenshi
• Created: 05/Jun/19 06:39
• Updated: 08/Aug/19 12:36
• Resolved: 08/Aug/19 04:26

Description

Potential NPE in ZookeeperFederationStateStore#getPoliciesConfigurations

The code of ZookeeperFederationStateStore#getPoliciesConfigurations

for (String child : zkManager.getChildren(policiesZNode)) {
  SubClusterPolicyConfiguration policy = getPolicy(child);
  result.add(policy);
}

The result of `getPolicy` may be null, so policy should be checked 

The new code 

for (String child : zkManager.getChildren(policiesZNode)) {
  SubClusterPolicyConfiguration policy = getPolicy(child);
  // policy maybe null, should check
  if (policy == null) {
    LOG.warn("Policy for queue: {} does not exist.", child);
    continue;
  }
  result.add(policy);
}

 

Issue Links

• links to: GitHub Pull Request #908