[YARN-9584] Should put initializeProcessTrees method call before get pid

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.2.0, 3.0.3, 3.1.2
• Fix Version/s: 3.3.0, 3.2.1, 3.1.3
• Component/s: nodemanager
• Hadoop Flags: Reviewed
• Assignee: Wanqiang Ji
• Reporter: Wanqiang Ji
• Created: 27/May/19 10:03
• Updated: 05/Jul/19 06:11
• Resolved: 18/Jun/19 06:19

Description

In ContainerMonitorImpl#MonitoringThread.run method had a logical error that get pid first then initialize uninitialized process trees. 

String pId = ptInfo.getPID();

// Initialize uninitialized process trees
initializeProcessTrees(entry);
if (pId == null || !isResourceCalculatorAvailable()) {
  continue; // processTree cannot be tracked
}

Issue Links

• is caused by: YARN-5776 Checkstyle: MonitoringThread.Run method length is too long