Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9453

Clean up code long if-else chain in ApplicationCLI#run

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:

      Description

      org.apache.hadoop.yarn.client.cli.ApplicationCLI#run is 630 lines long, contains a long if-else chain and many many conditions.
      As a start, the bodies of the conditions could be extracted to methods and a more clean solution could be introduced to parse the argument values.

        Attachments

        1. YARN-9453.001.patch
          68 kB
          Wanqiang Ji
        2. YARN-9453.002.patch
          66 kB
          Wanqiang Ji
        3. YARN-9453.003.patch
          66 kB
          Wanqiang Ji
        4. YARN-9453.004.patch
          66 kB
          Wanqiang Ji

          Activity

            People

            • Assignee:
              jiwq Wanqiang Ji
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: