Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9400

Remove unnecessary if at EntityGroupFSTimelineStore#parseApplicationId

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None

      Description

      If clause to validate whether appIdStr starts with "application" is not required at EntityGroupFSTimelineStore#parseApplicationId

       // converts the String to an ApplicationId or null if conversion failed
        private static ApplicationId parseApplicationId(String appIdStr) {
          ApplicationId appId = null;
          if (appIdStr.startsWith(ApplicationId.appIdStrPrefix)) {
            try {
              appId = ApplicationId.fromString(appIdStr);
            } catch (IllegalArgumentException e) {
              appId = null;
            }
          }
          return appId;
        }
      

        Attachments

        1. YARN-9400-001.patch
          2 kB
          Prabhu Joseph

          Activity

            People

            • Assignee:
              prabhujoseph Prabhu Joseph
              Reporter:
              prabhujoseph Prabhu Joseph
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: