[YARN-9400] Remove unnecessary if at EntityGroupFSTimelineStore#parseApplicationId

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Assignee: Prabhu Joseph
• Reporter: Prabhu Joseph
• Created: 20/Mar/19 06:23
• Updated: 23/Oct/19 16:14
• Resolved: 02/Sep/19 05:29

Description

If clause to validate whether appIdStr starts with "application" is not required at EntityGroupFSTimelineStore#parseApplicationId

 // converts the String to an ApplicationId or null if conversion failed
  private static ApplicationId parseApplicationId(String appIdStr) {
    ApplicationId appId = null;
    if (appIdStr.startsWith(ApplicationId.appIdStrPrefix)) {
      try {
        appId = ApplicationId.fromString(appIdStr);
      } catch (IllegalArgumentException e) {
        appId = null;
      }
    }
    return appId;
  }