Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6712 Moving logging APIs over to slf4j in hadoop-yarn
  3. YARN-9363

Replace isDebugEnabled with SLF4J parameterized log messages for remaining code

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: yarn
    • Labels:
      None

      Description

      Follow up of YARN-9343 to address below review comments

      There are still 200+ LOG.isDebugEnabled() calls in the code. two things:
      There are a lot of simple one parameter calls which could easily be converted to unguarded calls, examples:
      NvidiaDockerV1CommandPlugin.java
      FSParentQueue.java
      Application.java
      Some of the calls to LOG.debug that are guarded inside those guards have not been changed to parameterized calls yet.

      cc Wilfred Spiegelenburg

        Attachments

        1. YARN-9363-004.patch
          83 kB
          Prabhu Joseph
        2. YARN-9363-003.patch
          85 kB
          Prabhu Joseph
        3. YARN-9363-002.patch
          85 kB
          Prabhu Joseph
        4. YARN-9363-001.patch
          86 kB
          Prabhu Joseph

          Activity

            People

            • Assignee:
              Prabhu Joseph Prabhu Joseph
              Reporter:
              Prabhu Joseph Prabhu Joseph
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: