Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9362

Code cleanup in TestNMLeveldbStateStoreService

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are many ways to improve TestNMLeveldbStateStoreService:
      1. RecoveredContainerState fields are asserted many times repeatedly. Some simple method extractions would definitely make this more readable.
      2. The tests are very long and hard to read in general: Again, finding how methods could be extracted to avoid code repetition could help.
      3. You name it.

        Attachments

        1. YARN-9362.001.patch
          36 kB
          Denes Gerencser
        2. YARN-9362.002.patch
          36 kB
          Denes Gerencser

          Activity

            People

            • Assignee:
              denes.gerencser Denes Gerencser
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: