[YARN-9360] Do not expose innards of QueueMetrics object into FSLeafQueue#computeMaxAMResource

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Szilard Nemeth
• Created: 07/Mar/19 15:36
• Updated: 15/Jul/19 09:04
• Resolved: 15/Jul/19 09:04

Description

This is a follow-up for YARN-9323, covering required changes as discussed with templedf earlier.
After YARN-9323, org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue#computeMaxAMResource gets the QueueMetricsForCustomResources object from scheduler.getRootQueueMetrics().
Instead, we should use a "fill-in" method in QueueMetrics that receives a Resource and fills in custom resource values if they are non-zero.

Issue Links

• is cloned by: YARN-9361 Write testcase for FSLeafQueue that explicitly checks if non-zero AM-share values are not overwritten for custom resources