Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9355

RMContainerRequestor#makeRemoteRequest has confusing log message

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor#makeRemoteRequest has this log:

      if (ask.size() > 0 || release.size() > 0) {
            LOG.info("getResources() for " + applicationId + ":" + " ask="
                + ask.size() + " release= " + release.size() + " newContainers="
                + allocateResponse.getAllocatedContainers().size()
                + " finishedContainers=" + numCompletedContainers
                + " resourcelimit=" + availableResources + " knownNMs="
                + clusterNmCount);
          }
      

      The reason why "getResources()" is printed because org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator#getResources invokes makeRemoteRequest. This is not too informative and error-prone as name of getResources could change over time and the log will be outdated. Moreover, it's not a good idea to print a method name from a method below the current one in the stack.

        Attachments

          Activity

            People

            • Assignee:
              sahuja Siddharth Ahuja
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: