[YARN-9341] Reentrant lock() before try

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Fix Version/s: 3.3.0
• Component/s: yarn
• Assignee: Prabhu Joseph
• Reporter: Prabhu Joseph
• Created: 04/Mar/19 05:04
• Updated: 08/Jul/20 14:25
• Resolved: 07/Mar/19 21:49

Description

As a best practice - Reentrant lock has to be acquired before try clause.
https://stackoverflow.com/questions/31058681/java-locking-structure-best-pattern

There are many places where lock is obtained inside try.

    try {
       this.writeLock.lock();
      ....
    } finally {
      this.writeLock.unlock();
    }

Issue Links

• is duplicated by: YARN-10347 Fix double locking in CapacityScheduler#reinitialize in branch-3.1