Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9264 [Umbrella] Follow-up on IntelOpenCL FPGA plugin
  3. YARN-9270

Minor cleanup in TestFpgaDiscoverer

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.3.0
    • None
    • None
    • Reviewed

    Description

      Let's do some cleanup in this class.

      • testLinuxFpgaResourceDiscoverPluginConfig - this test should be split up to 5 different tests, because it tests 5 different scenarios.
      • remove setNewEnvironmentHack() - too complicated. We can introduce a Function in the plugin class like Function<String, String> envProvider = System::getenv() plus a setter method which allows the test to modify envProvider. Much simpler and straightfoward.

      Attachments

        1. YARN-9270-001.patch
          10 kB
          Peter Bacsko
        2. YARN-9270-002.patch
          25 kB
          Peter Bacsko
        3. YARN-9270-003.patch
          30 kB
          Peter Bacsko
        4. YARN-9270-004.patch
          30 kB
          Peter Bacsko
        5. YARN-9270-005.patch
          31 kB
          Peter Bacsko

        Activity

          People

            pbacsko Peter Bacsko
            pbacsko Peter Bacsko
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: