[YARN-9268] General improvements in FpgaDevice

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 01/Feb/19 12:13
• Updated: 25/Mar/19 20:45
• Resolved: 25/Mar/19 20:27

Description

Need to fix the following in the class FpgaDevice:

• It implements Comparable, but returns 0 in every case. There is no natural ordering among FPGA devices, perhaps "acl0" comes before "acl1", but this seems too forced and unnecessary.We think this class should not implement Comparable at all, at least not like that.
• Stores unnecessary fields: devName, busNum, temperature, power usage. For one, these are never needed in the code. Secondly, temp and power usage changes constantly. It's pointless to store these in this POJO.
• serialVersionUID is 1L - let's generate a number for this
• Use int instead of Integer - don't allow nulls. If major/minor uniquely identifies the card, then let's demand them in the constructor and don't store Integers that can be null.