Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Need to fix the following in the class FpgaDevice:

      • It implements Comparable, but returns 0 in every case. There is no natural ordering among FPGA devices, perhaps "acl0" comes before "acl1", but this seems too forced and unnecessary.We think this class should not implement Comparable at all, at least not like that.
      • Stores unnecessary fields: devName, busNum, temperature, power usage. For one, these are never needed in the code. Secondly, temp and power usage changes constantly. It's pointless to store these in this POJO.
      • serialVersionUID is 1L - let's generate a number for this
      • Use int instead of Integer - don't allow nulls. If major/minor uniquely identifies the card, then let's demand them in the constructor and don't store Integers that can be null.

        Attachments

        1. YARN-9268-001.patch
          14 kB
          Peter Bacsko
        2. YARN-9268-002.patch
          17 kB
          Peter Bacsko
        3. YARN-9268-003.patch
          17 kB
          Peter Bacsko
        4. YARN-9268-004.patch
          20 kB
          Peter Bacsko
        5. YARN-9268-005.patch
          20 kB
          Peter Bacsko
        6. YARN-9268-006.patch
          20 kB
          Peter Bacsko
        7. YARN-9268-007.patch
          20 kB
          Peter Bacsko

          Activity

            People

            • Assignee:
              pbacsko Peter Bacsko
              Reporter:
              pbacsko Peter Bacsko
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: