XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Problems identified in this class:

      • InnerShellExecutor ignores the timeout parameter
      • configureIP() uses printStackTrace() instead of logging
      • configureIP() does not log the output of aocl if the exit code != 0
      • parseDiagnoseInfo() is too heavyweight – it should be in its own class for better testability
      • downloadIP() uses contains() for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches)
      • method name downloadIP() is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point.
      • @VisibleForTesting methods should be package private
      • aliasMap is not needed - store the acl number in the FpgaDevice class
      • checkstyle fixes

        Attachments

        1. YARN-9266-001.patch
          39 kB
          Peter Bacsko
        2. YARN-9266-002.patch
          67 kB
          Peter Bacsko
        3. YARN-9266-003.patch
          68 kB
          Peter Bacsko
        4. YARN-9266-004.patch
          69 kB
          Peter Bacsko
        5. YARN-9266-005.patch
          72 kB
          Peter Bacsko
        6. YARN-9266-006.patch
          72 kB
          Peter Bacsko
        7. YARN-9266-007.patch
          72 kB
          Peter Bacsko
        8. YARN-9266-008.patch
          77 kB
          Peter Bacsko

          Issue Links

            Activity

              People

              • Assignee:
                pbacsko Peter Bacsko
                Reporter:
                pbacsko Peter Bacsko
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: