[YARN-9266] General improvements in IntelFpgaOpenclPlugin

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 01/Feb/19 11:58
• Updated: 12/Mar/19 21:28
• Resolved: 12/Mar/19 21:16

Description

Problems identified in this class:

• InnerShellExecutor ignores the timeout parameter
• configureIP() uses printStackTrace() instead of logging
• configureIP() does not log the output of aocl if the exit code != 0
• parseDiagnoseInfo() is too heavyweight – it should be in its own class for better testability
• downloadIP() uses contains() for file name check – this can really surprise users in some cases (eg. you want to use hello.aocx but hello2.aocx also matches)
• method name downloadIP() is misleading – it actually tries to finds the file. Everything is downloaded (localized) at this point.
• @VisibleForTesting methods should be package private
• aliasMap is not needed - store the acl number in the FpgaDevice class
• checkstyle fixes

Issue Links

• is depended upon by: YARN-9267 General improvements in FpgaResourceHandlerImpl